> For the complete documentation index, see [llms.txt](https://docs.flosum.com/llms.txt). Markdown versions of documentation pages are available by appending `.md` to page URLs; this page is available as [Markdown](https://docs.flosum.com/devops/pull-requests/pull-request-process/pull-request-step-2-reviewing.md).

# Pull Request Step 2: Reviewing

{% hint style="warning" %}

#### Written for the Old UI

This article was written for the old UI. The instructions are still usable, but the screenshots are outdated. In some cases, items referenced in the instructions have moved or changed. If you cannot find an item, see the [Where Did It Go](/devops/new-ui-ux-transition/where-did-it-go.md) article.
{% endhint %}

## ![](https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FG5ZbxX918xOHwbAwAJ4n%2FSummary2-Small-Icon.svg?alt=media\&token=da26a67f-ff7f-47b3-8669-06be960dc2d7) Overview

This article explains how to complete the Review process for a Pull Request, which involves both the creator and the assigned reviewers. Conducting thorough reviews is vital to maintaining code quality.

{% hint style="info" %}

#### Best Practices

* Always add at least one reviewer for accountability.
* Use the description field to summarize key changes for reviewers.
* Only merge when all conflicts are resolved and tests have passed.
* Use **Request Changes** instead of simply not approving, as it maintains a clear workflow.
* Avoid self-review and merging without a reviewer unless it’s a time-critical fix.
  {% endhint %}

### Pull Request Steps

Explore our series of articles that walk you through each step of the Pull Request process. You can read them in order or select a specific article for detailed guidance on a particular stage.

* [Pull Request Step 1: Creating](/devops/pull-requests/pull-request-process/pull-request-step-1-creating.md)
* [Pull Request Step 2: Reviewing](/devops/pull-requests/pull-request-process/pull-request-step-2-reviewing.md)
* [Pull Request Step 3: Merging](/devops/pull-requests/pull-request-process/pull-request-step-3-merging.md)

## Pull Request Overview Tab

The details of a Pull Request help reviewers and contributors gain context about the request. The **Overview** tab has two sections to review: **Pull Request Details** and **Pull Request Reviewers**.

<div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FBRYwguQOGMaWimAFbN7K%2FPullRequestReviewing-Overview-01.png?alt=media&amp;token=59696f06-e359-4855-abb0-007c998e0e52" alt="" width="563"><figcaption></figcaption></figure></div>

### Pull Request Details

<table><thead><tr><th width="160">Field</th><th>Description</th></tr></thead><tbody><tr><td><strong>Status</strong></td><td>Current state of the Pull Request (<strong>Created</strong>, <strong>Review Requested</strong>, <strong>Changes Requested</strong>, and <strong>Approved</strong>).</td></tr><tr><td><strong>Target branch</strong></td><td>The branch where changes will be merged.</td></tr><tr><td><strong>Source branch</strong></td><td>The branch where changes originate.</td></tr><tr><td><strong>Created by</strong></td><td>User who created the Pull Request.</td></tr><tr><td><strong>Created date</strong></td><td>When the Pull Request was first created.</td></tr><tr><td><strong>Updated date</strong></td><td>When the last activity or change to the Pull Request happened.</td></tr><tr><td><strong>Description</strong></td><td>Summary of the changes for this Pull Request. Written by the creator of the Pull Request.</td></tr></tbody></table>

### Pull Request Reviewers

The **Reviewers** section shows the users assigned to review this Pull Request. The status of each reviewer is indicated by an icon that illustrates the review state (review pending, requested changes, or approved). See the instructions below for more details on the review process.

## Review Pull Request

{% stepper %}
{% step %}

### Wait for Merge Conflicts Check

1. When a Pull Request is created, it initially checks for merge conflicts, indicated by a grey banner.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FNszuvoCa9QQTAF4RFsx3%2FPullRequestReviewing-S01-01.png?alt=media&amp;token=1461350d-8dd5-4059-ac0f-2ec196f4f02d" alt="" width="563"><figcaption></figcaption></figure></div>
2. Wait for the banner to change to one of the following:
   1. **Green**: This branch is able to merge
   2. **Orange**: This branch has conflicts that must be resolved
3. If the branch is able to merge, you can continue reviewing the Pull Request by following the instructions in this article.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FvxrujNjV46kt1A1BMwAo%2FPullRequestReviewing-S01-02.png?alt=media&amp;token=9e1ad90a-51dc-43bb-954e-f82b3f5bf622" alt="" width="375"><figcaption></figcaption></figure></div>
4. If the branch has conflicts, you must resolve the conflicts before continuing to review this Pull Request. See the following article to learn how to resolve conflicts.
   1. [Resolving Pull Request Conflicts](/devops/pull-requests/pull-request-process/resolving-pull-request-conflicts.md)
      {% endstep %}

{% step %}

### (Optional) Add Reviewers

Adding reviewers ensures code quality, helps identify conflicts early, and enforces team approval processes. All reviewers must click **Approve** before the Pull Request can be merged.

{% hint style="success" %}

#### Self-Review

If no reviewers are added, you can review your own Pull Request changes. No formal review or approval is required. After reviewing, you may merge without additional approval.
{% endhint %}

1. In the **Reviewers** section, click the **Pencil** icon.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2F28Zho7daWf4WY8z0uhjV%2FPullRequestReviewing-S02-01.png?alt=media&amp;token=7c43829b-5f00-4d56-ae81-f4f406347529" alt="" width="563"><figcaption></figcaption></figure></div>
2. Click **Add** for each user you want to review this Pull Request.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2F51xaVcK8V3PW05ZBYbM4%2FPullRequestReviewing-S02-02.png?alt=media&amp;token=019baa20-fcdd-4dba-b9ce-274313a65575" alt="" width="375"><figcaption></figcaption></figure></div>
3. Click **Save**.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2F1jEfZrBTs2qkOQuqQNtV%2FPullRequestReviewing-S02-03.png?alt=media&amp;token=a3226472-5ea1-479b-a0e5-6f7adfb3f400" alt="" width="375"><figcaption></figcaption></figure></div>
4. The added reviewers will be listed in the **Reviewers** section, and the Pull Request status will change to **Review Requested**.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2F9y22mlFuqUNLxood84er%2FPullRequestReviewing-S02-04.png?alt=media&amp;token=d43f786f-671b-486e-922b-acee09960900" alt="" width="563"><figcaption></figcaption></figure></div>

{% endstep %}

{% step %}

### Review Changes

To review the Pull Request, each reviewer must log into Cloud DevOps and follow these steps:

{% hint style="info" %}
Pull requests awaiting review are marked with the status **Review Requested**, and the **Reviewers**' icons are displayed.
{% endhint %}

{% hint style="success" %}

#### Self-Review

If you are self-reviewing, you must still review each component before merging.
{% endhint %}

1. Click **Pull requests** from the left sidebar menu.
2. Click the Pull Request to review.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FAqKE9j73OKUHh5CoAD8y%2FPullRequestReviewing-S03-01.png?alt=media&amp;token=4663cae1-4c59-4a2b-9e9c-1c18b52f40bc" alt="" width="563"><figcaption></figcaption></figure></div>
3. Click the **Components changed** tab.
4. Click a component to review.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FDpVD3gOYXoVoCSJTDrRP%2FPullRequestReviewing-S03-02.png?alt=media&amp;token=fcb6ef95-6da5-4919-98a8-b146fcce4d2c" alt="" width="563"><figcaption></figcaption></figure></div>

{% hint style="warning" %}
All components should be reviewed.
{% endhint %}

5. When viewing a component, the source code for **Target** and **Source** is displayed side-by-side with differences highlighted.

   1. **Red**: Lines to be removed.
   2. **Green**: Lines to be added.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FoPOvjdDju542rvYZmtky%2FPullRequestReviewing-S03-03.png?alt=media&amp;token=9393dac8-de18-47f7-bb63-6a3a884896eb" alt="" width="563"><figcaption></figcaption></figure></div>
6. Repeat the review process for each component.
   {% endstep %}

{% step %}

### (Optional) Request Changes

When reviewing, use **Request Changes** to indicate that fixes are needed before approval. This status prompts the Pull Request creator to update the source branch with the necessary changes. Since the request doesn't specify what needs to be changed, communicate the specific changes required directly to your team.

{% hint style="success" %}

#### Self-Review

If you are self-reviewing, you can't **Request Changes**.
{% endhint %}

1. Click **Request changes**.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FmtUEh3cAxhX6qDQ2Ysqw%2FPullRequestReviewing-S04-01.png?alt=media&amp;token=5c2674af-b702-46b9-8db6-70062b4e5e92" alt="" width="563"><figcaption></figcaption></figure></div>
2. After requesting changes, the Pull Request status will change to **Changes Requested**.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2Fh3WNpmtsxw7JosB8f1Ie%2FPullRequestReviewing-S04-02.png?alt=media&amp;token=9477d9c8-cd12-4471-a5cd-2d64361e6f29" alt="" width="563"><figcaption></figcaption></figure></div>

#### Resubmit for Review

After making the requested changes, resubmit the Pull Request for review by the Reviewer who requested them.

1. Click the Pull Request.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FQ0Fd4L7MCILU6c4gukdY%2FPullRequestReviewing-S04-03.png?alt=media&amp;token=71acd999-72d9-447a-a378-2d4ef73b380e" alt="" width="563"><figcaption></figcaption></figure></div>
2. Click the **Refresh** icon next to the reviewer who requested the review.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FIGx3xI7UlUb33mHTobYV%2FPullRequestReviewing-S04-04.png?alt=media&amp;token=3312a2d2-a65d-4662-b5f8-de766e7eb862" alt="" width="563"><figcaption></figcaption></figure></div>

{% endstep %}

{% step %}

### Approve

Once a reviewer has completed their review of all components and any completed change requests, they must approve the Pull Request before it can be merged.

{% hint style="warning" %}
The Pull Request will not be approved until all reviewers click **Approve**.
{% endhint %}

{% hint style="success" %}

#### Self-Review

When self-reviewing, you can't **Approve** the Pull Request. But since there are no reviewers, approval is not required before merging.
{% endhint %}

1. Click **Approve**.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2F0iNVhb6mdclluMAmW1Aw%2FPullRequestReviewing-S05-01.png?alt=media&amp;token=9f2b7510-c159-4cb7-a4e1-1b4d7766517e" alt="" width="563"><figcaption></figcaption></figure></div>
2. After all reviewers approve, the Pull Request status will change to **Approved**, and it can be merged.

   <div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2F4F8u8tx6fNcpLXXthvja%2FPullRequestReviewing-S05-02.png?alt=media&amp;token=458e0f62-a12f-4777-ba07-1ffcd1d2e135" alt="" width="563"><figcaption></figcaption></figure></div>

{% endstep %}

{% step %}

### Next Step: Merging

After the Pull Request is approved, the changes from the source branch are ready to be merged into the target branch. Proceed to the following article for instructions on the merge process.

* [Pull Request Step 3: Merging](/devops/pull-requests/pull-request-process/pull-request-step-3-merging.md)

<div align="left"><figure><img src="https://1800549522-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FRpUu5iMlzMFAudyBvMOl%2Fuploads%2FG9DKua3MnrgmW0zZinu4%2FPullRequestReviewing-S06-01.png?alt=media&amp;token=132d0dc1-87b8-438e-a64e-96e0055e7f5b" alt="" width="563"><figcaption></figcaption></figure></div>
{% endstep %}
{% endstepper %}


---

# Agent Instructions
This documentation is published with GitBook. GitBook is the documentation platform designed so that both humans and AI agents can read, navigate, and reason over technical content effectively. Learn more at gitbook.com.

## Querying This Documentation
If you need additional information that is not directly available in this page, you can query the documentation by asking a question.

Perform an HTTP GET request on the following URL with the `ask` and `goal` query parameters:

```
GET https://docs.flosum.com/devops/pull-requests/pull-request-process/pull-request-step-2-reviewing.md?ask=<question>&goal=<user_goal>
```

`ask` is the immediate question: it should be specific, self-contained, and written in natural language.
`goal` is what the user is ultimately trying to achieve, the reason they need the answer. Sharing it helps GitBook give you a better, more relevant answer. A goal is most helpful when it describes the outcome the user wants rather than restating the question. For example, with `ask=how do I create an API token`, a goal like `automate deployments from our CI pipeline` lets GitBook tailor the answer to that use case.

The response will contain a direct answer to the question and relevant excerpts and sources from the documentation.

Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.